Skip to content

translation of filecmp.po#618

Merged
JulienPalard merged 18 commits into
python:3.7from
Zepmanbc:3.7
Mar 29, 2019
Merged

translation of filecmp.po#618
JulienPalard merged 18 commits into
python:3.7from
Zepmanbc:3.7

Conversation

@Zepmanbc

@Zepmanbc Zepmanbc commented Mar 21, 2019

Copy link
Copy Markdown
Contributor

No description provided.

Seluj78
Seluj78 requested changes Mar 21, 2019
View reviewed changes

@Seluj78 Seluj78 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup pour ta contribution ! Je ne l'ai relue que pour les erreurs RST. Il faut que tu passe powrap sur le fichier dit travis ;)

Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
@Zepmanbc
transtale filecmp
b1a70e9 
ajout des espaces avant les ':'
passage par `powrap`
@Zepmanbc

Zepmanbc commented Mar 22, 2019

Copy link
Copy Markdown
Contributor Author

🎉 le build est passé

@Zepmanbc

Zepmanbc commented Mar 22, 2019

Copy link
Copy Markdown
Contributor Author

comment ça se passe après? je dois faire quelque chose d'autre? c'est toi qui ferme mon issue?

@Seluj78

Seluj78 commented Mar 22, 2019

Copy link
Copy Markdown
Collaborator

Alors du coup on va relire encore, perso j'ai relu principalement pour la syntaxe. Une fois que tout le monde est daccord et approuvent la PR alors @JulienPalard ou @christopheNan merge

christopheNan
christopheNan suggested changes Mar 22, 2019
View reviewed changes

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette très bonne contribution. Juste quelques remarques.

Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
Comment thread library/filecmp.po Outdated
christopheNan and others added 9 commits March 23, 2019 09:15
@christopheNan @Zepmanbc
Update library/filecmp.po
1d967ed 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
150d352 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
6153afd 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
f849e6d 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
f82dfda 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
624d92d 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
3582bc5 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@christopheNan @Zepmanbc
Update library/filecmp.po
81b2232 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@Zepmanbc
translate filecmp.po
b215a3f 
modification suite au retour de christopheNan
JulienPalard
JulienPalard requested changes Mar 26, 2019
View reviewed changes

@JulienPalard JulienPalard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

Comment thread library/filecmp.po Outdated
@JulienPalard @Zepmanbc
Update library/filecmp.po
b99d0bf 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@Seluj78

Seluj78 commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

@Zepmanbc gaffe, github a plein de suggestions marquées en outdated. Vérifie qu'elles ai été implémentées avant de les mettre en resolved

@Zepmanbc

Zepmanbc commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

@Seluj78 j'ai appliqué toutes les modifications à la main, je n'ai pas cliqué sur Commit suggestion à chaque fois. Il fallait?
Quelle est la bonne façon de faire? (il existe un guide du genre "les bonnes pratiques du commiteur" ?)

@Seluj78

Seluj78 commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

@Zepmanbc https://help.github.com/en/articles/incorporating-feedback-in-your-pull-request#applying-a-suggested-change ;)

@christopheNan @Zepmanbc
Update library/filecmp.po
399ee24 
Co-Authored-By: Zepmanbc <zepman@gmail.com>
@Zepmanbc

Zepmanbc commented Mar 27, 2019

Copy link
Copy Markdown
Contributor Author

@Seluj78 merci
Donc soit j'utilise le bouton [Commit suggestion], soit je le fait "à la main" et je clique sur [Resolve conversation]
normalement j'ai fait le tour
la prochaine ira mieux, je serai un peu moins boulet normalement ^^

@Seluj78

Seluj78 commented Mar 27, 2019

Copy link
Copy Markdown
Collaborator

yes exactement ! Et si tu va dans l'onglet files changed de github tu peux appliquer les suggestions en batch :D

christopheNan
christopheNan approved these changes Mar 27, 2019
View reviewed changes

@christopheNan christopheNan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Très bonne contribution. Merci !

@JulienPalard

JulienPalard commented Mar 29, 2019

Copy link
Copy Markdown
Member

Top ! Merci pour cette PR \o/

@JulienPalard
JulienPalard merged commit 5238d09 into python:3.7 Mar 29, 2019
@Seluj78 Seluj78 mentioned this pull request Apr 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard requested changes
@Seluj78 Seluj78 Seluj78 requested changes
+1 more reviewer
@christopheNan christopheNan christopheNan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zepmanbc @Seluj78 @JulienPalard @christopheNan